Cannot delete unused tasks

[Didayolo]

Note that I have 138 unused tasks. When I try to delete them by clicking on Delete unused tasks, I get the following error message:

I see no specific logs in the containers.

Todos:

• decide solution for this problem
• Fix the problem

[ihsaan-ullah]

are you getting this when you click this new button Delete unused tasks?

[ihsaan-ullah]

I am going to add logs so that we can see the real error in django

[Didayolo]

are you getting this when you click this new button Delete unused tasks?

Yes

[ihsaan-ullah]

This is happening because of this line of code

codabench/src/apps/competitions/models.py

Line 443 in 1524632

task = models.ForeignKey(Task, on_delete=models.PROTECT, null=True, blank=True, related_name="submissions")

The reason of this is that you had a task used in a competition, now you have removed it from the competiiton but one or more submissions have already used this task.

[ihsaan-ullah]

Solutions for this:

1. change model.PROTECT to SETNULL
2. don't delete tasks used in a submission

[ihsaan-ullah]

@Didayolo can you also check if you still have 138 tasks after the error or some are deleted?

[Didayolo]

Thanks for the input.

can you also check if you still have 138 tasks after the error or some are deleted?

The 138 tasks are remaining

[Didayolo]

don't delete tasks used in a submission

I'm not sure if I understand this point

[Didayolo]

With the new change, the logger returns this when it fails:

django_1          | UNUSED TASKS DELETION --- ("Cannot delete some instances of model 'Task' because they are referenced through a protected foreign key: 'Submission.task'", <QuerySet [<Submission: Cross-Domain MetaDL submission PK=4037 by pavaotest>, <Submission: Mini-AutoML submission PK=8351 by pavao>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9219 by pavao>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=8923 by pavao>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=8925 by bdonnot>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=8926 by bdonnot>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=8927 by bdonnot>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=8928 by bdonnot>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9070 by pavao>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9071 by pavao>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9116 by pavao>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9227 by pavao>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9195 by bdonnot>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9228 by bdonnot>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9036 by pavao>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9238 by pavao>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9240 by bdonnot>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9054 by bdonnot>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9220 by pavao>, <Submission: [L2RPN 2023] Paris Region AI Challenge Energy Transition submission PK=9254 by bdonnot>, '...(remaining elements truncated)...']>)

The reason of this is that you had a task used in a competition, now you have removed it from the competiiton but one or more submissions have already used this task.

Given the logs, I think that you are right.

Solution 1: change model.PROTECT to SETNULL

This is done by this PR: #994

Solution 2: don't delete tasks used in a submission

Then would it be possible to remove a task used in a submission? Solution 1 seems more satisfying but I am not sure of the implications

[Didayolo]

I merged the Solution 1. It is the responsability of organizers to not delete unused tasks if they plan to re-use a task that have previous submissions.