Skip to content

Competition - reward, contact_email, report#1063

Merged
Didayolo merged 7 commits into
developfrom
competition_reward_contact_report
Aug 22, 2023
Merged

Competition - reward, contact_email, report#1063
Didayolo merged 7 commits into
developfrom
competition_reward_contact_report

Conversation

@ihsaan-ullah

@ihsaan-ullah ihsaan-ullah commented Aug 6, 2023

Copy link
Copy Markdown
Collaborator

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now users can add the following to their competition

  1. contact email
  2. reward text
  3. report link

What is done in this PR

  • Add/Update contact email
  • Add/Update reward text
  • Add/Update report link
  • Add these in competition creation and updation
  • Add contact_email and reward in yaml
  • update v2 unpacker to unpack contact_email and reward
  • show contact_email in forum
  • Show reward in competition list card

Screenshots

When contact email,reward, and report are not added
Screenshot 2023-06-25 at 1 37 28 AM

When all of these are added
Screenshot 2023-06-25 at 1 37 46 AM

These can be added in the editor
Screenshot 2023-06-25 at 1 37 58 AM

YAML file can have contact_email and reward as shown below
Screenshot 2023-06-25 at 1 51 02 AM

Competition unpacked using V2 unpacker using the above YAML
Screenshot 2023-06-25 at 1 54 10 AM

Contact email in forum
Screenshot 2023-06-25 at 2 23 20 AM

Competition list shows reward icon when competition has reward
Screenshot 2023-06-25 at 2 40 28 AM
Screenshot 2023-06-25 at 2 40 19 AM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah

Copy link
Copy Markdown
Collaborator Author

@Didayolo can you please check this PR locally. It works locally with me and the tests are also passing locally.

Branch:
Screenshot 2023-08-06 at 12 56 35 PM

Tests:
Screenshot 2023-08-06 at 12 58 06 PM
Screenshot 2023-08-06 at 12 58 18 PM

@Didayolo

Didayolo commented Aug 9, 2023

Copy link
Copy Markdown
Member

@ihsaan-ullah : So we still have a problem with CircleCI everytime you create this reward field?

On a side note, the style should be improved (the emails are not using the right blue color, also Competition report should use the same blue as Docker image).

@ihsaan-ullah

Copy link
Copy Markdown
Collaborator Author

@ihsaan-ullah : So we still have a problem with CircleCI everytime you create this reward field?

Yes, this issue is weird

On a side note, the style should be improved (the emails are not using the right blue color, also Competition report should use the same blue as Docker image).

I will change the style

@ihsaan-ullah

Copy link
Copy Markdown
Collaborator Author
Screenshot 2023-08-09 at 4 11 34 PM

Report url style changed, copy button added

email style is already like docker image

@Didayolo

Didayolo commented Aug 9, 2023

Copy link
Copy Markdown
Member

And what about this page? Here Start a new one is using the blue used for clickable links in Codabench

Capture d’écran 2023-08-09 à 13 18 44

@ihsaan-ullah

Copy link
Copy Markdown
Collaborator Author
Screenshot 2023-08-09 at 4 37 29 PM Forum contact email color changed

@Didayolo

Didayolo commented Aug 9, 2023

Copy link
Copy Markdown
Member

Good job. Now we really need to investigate together this problem of auto-tests.

@ihsaan-ullah

Copy link
Copy Markdown
Collaborator Author

Good job. Now we really need to investigate together this problem of auto-tests.

Discussed this with Tuan. The functionality and tests both work with me locally. If we can verify that everything works locally with you and Tuan, then we can be sure that the problem could come from circle ci tests.

@dtuantran

Copy link
Copy Markdown
Contributor

I've the same error when trying locally
image

@Didayolo

Copy link
Copy Markdown
Member

I have the same error locally too, even if I run the migration before

@ihsaan-ullah

Copy link
Copy Markdown
Collaborator Author

@Didayolo Didayolo merged commit 38585d9 into develop Aug 22, 2023
@Didayolo Didayolo deleted the competition_reward_contact_report branch August 22, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants