Skip to content

Hide leaderboard when leaderboard is hidden #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Didayolo merged 1 commit into from
Sep 9, 2023
Merged

Hide leaderboard when leaderboard is hidden #1147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/static/riot/competitions/detail/_tabs.tag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,15 +186,18 @@
</div>
</div>
</div>
<leaderboards class="leaderboard-table"
<!-- If there's no leaderboard, show this message -->
<div show="{_.isEmpty(competition.leaderboards)}">
<div class="center aligned"><h2>No visible leaderboard for this benchmark</h2></div>
</div>
<!-- Else, show the leaderboard -->
<div show="{!_.isEmpty(competition.leaderboards)}">
<leaderboards class="leaderboard-table"
phase_id="{ self.selected_phase_index }"
is_admin="{competition.admin}">
</leaderboards>
</div>
<div show="{!loading && _.isEmpty(competition.leaderboards)}">
<div class="center aligned"><h2>No Visible Leaderboards for this competition</h2></div>
</div>

</leaderboards>
</div>
</div>
</div>
</div>

Expand Down