Skip to content

Show error in scoring std_err #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Didayolo merged 2 commits into from
Jan 18, 2024
Merged

Show error in scoring std_err #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9332bdd
show docker pull or execution time limit error in scoring_std_err whe…
ihsaan-ullah Nov 5, 2023
1bc1fec
Update submissions.py
ihsaan-ullah Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compute_worker/compute_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,7 @@ def _get_container_image(self, image_name):
docker_pull_fail_data = {
"type": "Docker_Image_Pull_Fail",
"error_message": error_message,
"is_scoring": self.is_scoring
}
# Send data to be written to ingestion logs
self._update_submission(docker_pull_fail_data)
Expand Down
5 changes: 2 additions & 3 deletions src/apps/api/views/submissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@ def check_object_permissions(self, request, obj):
# Set file name to ingestion std error as default
error_file_name = "prediction_ingestion_stderr"

# Change error file name when error comes from execution time limit
# and error occured during scoring
if request.data["type"] == "Execution_Time_Limit_Exceeded" and request.data['is_scoring'] == "True":
# Change error file name to scoring_stderr when error occurs during scoring
if request.data.get("is_scoring", "False") == "True":
error_file_name = "scoring_stderr"

try:
Expand Down