Skip to content

Show server error instead of fronend parsing/JSON error #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Didayolo merged 1 commit into from
Mar 20, 2025
Merged

Show server error instead of fronend parsing/JSON error #1781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions src/static/riot/competitions/detail/submission_upload.tag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,23 +477,12 @@
if (response) {
try {
let errors = JSON.parse(response.responseText)

// Clean up errors to not be arrays but plain text
Object.keys(errors).map(function (key, index) {
errors[key] = errors[key].join('; ')
})

// Create a string to concatenate all error messages
let errorMessages = "Error in submission upload:\n"
Object.keys(errors).forEach(function (key) {
errorMessages += key + ": " + errors[key] + "\n"
})

toastr.error(errorMessages)
let error_str = Object.keys(errors).map(function (key) { return errors[key] }).join("; ")
toastr.error("Submission upload failed: " + error_str)
self.update({errors: errors})

} catch (e) {
toastr.error("Error in submission upload\n"+e)
toastr.error("Submission upload failed. Server returned: " + response.status + " " + response.statusText);
}
} else {
toastr.error("Something went wrong, please try again later")
Expand Down