Skip to content

Clean minor code logic problems in submission_upload.tag #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ObadaS merged 1 commit into from
Mar 24, 2026
Merged

Clean minor code logic problems in submission_upload.tag #2276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/static/riot/competitions/detail/submission_upload.tag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@
self.handle_websocket(event_data.submission_id, data)
}
})
self.detailed_result_urls[submission_id] = detailed_result_url
self.detailed_result_urls[event_data.submission_id] = detailed_result_url
self.update()
break
case 'message':
Expand Down Expand Up @@ -443,7 +443,7 @@
}
}
}
return form_json === {} ? null : form_json
return _.isEmpty(form_json) ? null : form_json
}

self.upload = function () {
Expand Down Expand Up @@ -472,7 +472,7 @@
self.lines = {}
let dropdown = $('#organization_dropdown')
let organization = dropdown.dropdown('get value')
if(organization === 'add_organization' | organization === 'None'){
if(organization === 'add_organization' || organization === 'None'){
organization = null
}
dropdown.attr('disabled', 'disabled')
Expand Down