Feature group routing for submissions#2393
Merged
Merged
Conversation
14 tasks
Member
|
This feature can't be considered ready while there are failures in the CircleCI tests: =========================== short test summary info ============================
FAILED src/apps/api/tests/test_competitions.py::CompetitionTests::test_delete_own_competition - django.db.utils.ProgrammingError: relation "competitions_competition_partic...
FAILED src/apps/api/tests/test_leaderboards.py::CompetitionLeaderboardStressTests::test_getting_many_submissions_doesnt_cause_too_many_queries - AssertionError: 31 != 11 : 31 queries executed, 11 expected
FAILED src/apps/api/tests/test_phases.py::ReRunPhaseSubmissionTests::test_collab_can_re_run_whole_phase - django.db.utils.InternalError: current transaction is aborted, commands ign...
FAILED src/apps/api/tests/test_phases.py::ReRunPhaseSubmissionTests::test_comp_creator_can_re_run_whole_phase - django.db.utils.InternalError: current transaction is aborted, commands ign...
FAILED src/apps/api/tests/test_phases.py::ReRunPhaseSubmissionTests::test_normal_user_cannot_re_run_whole_phase - django.db.utils.InternalError: current transaction is aborted, commands ign...
FAILED src/apps/api/tests/test_phases.py::ReRunPhaseSubmissionTests::test_super_user_can_re_run_whole_phase - django.db.utils.InternalError: current transaction is aborted, commands ign...
FAILED src/apps/api/tests/test_queues.py::QueuesAPITestCase::test_organizer_can_perform_all_operations - django.db.utils.ProgrammingError: relation "profiles_customgroup" does not ...
FAILED src/apps/api/tests/test_submissions.py::OrganizationSubmissionTests::test_org_participant_can_make_submission_as_organization - django.db.utils.InternalError: current transaction is aborted, commands ign...
FAILED src/apps/api/tests/test_submissions.py::TaskSelectionTests::test_can_re_run_submissions_with_multiple_tasks - django.db.utils.InternalError: current transaction is aborted, commands ign...
FAILED src/apps/api/tests/test_submissions.py::TaskSelectionTests::test_can_re_run_submissions_with_specific_task_with_bot_user_without_original_submission_secret - django.db.utils.InternalError: current transaction is aborted, commands ign...
FAILED src/apps/api/tests/test_submissions.py::TaskSelectionTests::test_can_select_tasks_when_making_submissions - django.db.utils.InternalError: current transaction is aborted, commands ign...
FAILED src/apps/competitions/tests/test_submissions.py::SubmissionManagerTests::test_re_run_submission_creates_new_submission_with_same_data_owner_and_phase - django.db.utils.InternalError: current transaction is aborted, commands ign...
FAILED src/apps/competitions/tests/test_submissions.py::MultipleTasksPerPhaseTests::test_children_always_created_in_the_same_order - AssertionError: assert 0 == 2
FAILED src/apps/competitions/tests/test_submissions.py::MultipleTasksPerPhaseTests::test_making_submission_creates_parent_sub_and_additional_sub_per_task - AssertionError: assert 0 == 2
FAILED src/apps/competitions/tests/test_submissions.py::MultipleTasksPerPhaseTests::test_making_submission_to_phase_with_one_task_does_not_create_parents_or_children - AssertionError: assert 0 == 1
===== 15 failed, 222 passed, 2 skipped, 2285 warnings in 347.97s (0:05:47) =====
Exited with code exit status 1 |
5e3ff22 to
83be794
Compare
Member
Collaborator
|
When someone makes a submission while a group, then add their submission to the leaderboard, the leaderboard correctly shows the name of the group. However, if the person is removed from the group, the leaderboard will start showing the name of the Queue that the submission was made on instead, which could lead to confusion. If the person is put back into the group, the leaderboard will go back to showing the name of the group. |
Didayolo
approved these changes
Jun 16, 2026
Member
|
Approved. Still TODO:
|
IdirLISN
added a commit
that referenced
this pull request
Jun 16, 2026
* backend & frontend OK / TODO: site worker and leaderboad * site worker sending submissions to group queue OK * leaderboad group feature * logs removed * fix json leaderboard * Clean up leaderboard ordering logic * competition queue on groups with out queue * some bugfix * UI bugfix * UI bugfix * leaderboard groups format parentsubID_groupname * fix conflicts issues * resolve conflict * clean site worker * branch update and linter fix * linter fix * linter fix * linter fix * bugfix group form * adding migrations files * fix logic to fix tests problem * fix logic to fix tests problem * E2E test fixed * E2E test fixed * E2E test fixed * E2E test fixed * Fix queue name in server status * fix queues visibility * fix queue visibility for groups * Flake8 --------- Co-authored-by: didayolo <adrien.pavao@gmail.com>
IdirLISN
added a commit
that referenced
this pull request
Jun 16, 2026
* backend & frontend OK / TODO: site worker and leaderboad * site worker sending submissions to group queue OK * leaderboad group feature * logs removed * fix json leaderboard * Clean up leaderboard ordering logic * competition queue on groups with out queue * some bugfix * UI bugfix * UI bugfix * leaderboard groups format parentsubID_groupname * fix conflicts issues * resolve conflict * clean site worker * branch update and linter fix * linter fix * linter fix * linter fix * bugfix group form * adding migrations files * fix logic to fix tests problem * fix logic to fix tests problem * E2E test fixed * E2E test fixed * E2E test fixed * E2E test fixed * Fix queue name in server status * fix queues visibility * fix queue visibility for groups * Flake8 --------- Co-authored-by: didayolo <adrien.pavao@gmail.com>
5 tasks
Didayolo
added a commit
that referenced
this pull request
Jun 19, 2026
* backend & frontend OK / TODO: site worker and leaderboad * site worker sending submissions to group queue OK * leaderboad group feature * logs removed * fix json leaderboard * Clean up leaderboard ordering logic * competition queue on groups with out queue * some bugfix * UI bugfix * UI bugfix * leaderboard groups format parentsubID_groupname * fix conflicts issues * resolve conflict * clean site worker * branch update and linter fix * linter fix * linter fix * linter fix * bugfix group form * adding migrations files * fix logic to fix tests problem * fix logic to fix tests problem * E2E test fixed * E2E test fixed * E2E test fixed * E2E test fixed * Fix queue name in server status * fix queues visibility * fix queue visibility for groups * Flake8 --------- Co-authored-by: didayolo <adrien.pavao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adding button inside the edit section of competitions, participant page, to create groups of users linked to a queue.
In edit section of competition, we can now create groups for this specific competition, edit groups, add participant to groups and associate a queue to groups.
If a user is inside multiple groups when he submits, multiple child submission are created (1 per group).
Each child submission are displayed in lines inside of the leaderboard ordered by ranking.
Multitasking is supported.
Issues this PR resolves
Closes #2100
/!\ new migrations files. /!\
A checklist for hand testing
Checklist