Skip to content

fix: add retry with backoff to _update_submission and stop swallowing… #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dconstancy wants to merge 2 commits into
base: develop
Choose a base branch
from
+9 −5
Open

fix: add retry with backoff to _update_submission and stop swallowing… #2416

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
058e233
fix: add retry with backoff to _update_submission and stop swallowing…
Jun 16, 2026
bbdbcbc
fix: address review comments on _update_submission
dconstancy Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions compute_worker/compute_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,8 +503,10 @@ def __init__(self, run_args):
self.requests_session = requests.Session()
adapter = requests.adapters.HTTPAdapter(
max_retries=Retry(
total=3,
backoff_factor=1,
total=5,
backoff_factor=2,
status_forcelist=[502, 503, 504],
allowed_methods=["PATCH", "GET", "PUT"],
)
)
self.requests_session.mount("http://", adapter)
Expand Down Expand Up @@ -618,14 +620,15 @@ def _update_submission(self, data):
url = f"{self.submissions_api_url}/submissions/{self.submission_id}/"
data["secret"] = self.secret

logger.info(f"Updating submission @ {url} with data = {data}")
logger.info(f"Updating submission @ {url}")

resp = self.requests_session.patch(url, data=data, timeout=150)
if resp.status_code == 200:
logger.info("Submission updated successfully!")
else:
logger.error(
f"Submission patch failed with status = {resp.status_code}, and response = \n{resp.content}"
f"Submission patch failed with status = {resp.status_code}, "
f"and response = \n{resp.content}"
)
raise SubmissionException("Failure updating submission data.")

Expand All @@ -639,8 +642,9 @@ def _update_status(self, status, extra_information=None):
try:
self._update_submission(data)
except Exception as e:
# Always catch exception and never raise error
logger.exception(f"Failed to update submission status to {status}: {e}")
if status in ("Finished", "Failed"):
raise

def _get_container_image(self, image_name):
logger.info("Running pull for image: {}".format(image_name))
Expand Down