fix: allow organizers to hard-delete soft-deleted submissions#2422
Open
dconstancy wants to merge 1 commit into
Open
fix: allow organizers to hard-delete soft-deleted submissions#2422dconstancy wants to merge 1 commit into
dconstancy wants to merge 1 commit into
Conversation
Add a delete button visible to organizers on soft-deleted submissions, and guard against None data in delete/soft_delete methods.
dconstancy
force-pushed
the
fix/quota-exclude-cancelled-submissions
branch
from
d16ddf8 to
600c3c5
Compare
dconstancy
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following feedback on the original approach (excluding Cancelled from quota),
this PR takes the suggested route: let organizers hard-delete soft-deleted
submissions so they can free up quota manually.
Issues this PR resolves
Changes
submission_manager.tag): Add a delete button (trash icon)on soft-deleted submissions, visible to organizers only.
models.py): Guardself.dataaccess indelete()andsoft_delete()— after a soft-delete,self.dataisNone, which causedan
AttributeErrorwhen trying to hard-delete.A checklist for hand testing
Checklist