Better admin output for email text and subject. Fixes failures for emails with Subject/From/To fields missing.#5
Merged
coddingtonbear merged 5 commits intocoddingtonbear:masterfrom Jul 27, 2013
Conversation
attachments' name, message header, etc. * Remove overriding for MessageAttachment's __getitem__ method, so we can call the members directly in django templates. Signed-off-by: Anders.Du <ander.dy@gmail.com>
jhmaddox/django-precompressed#1 ("AttributeError: StringIO instance has no attribute 'name'")
Owner
There was a problem hiding this comment.
I'm afraid much of this conditional block is handled by email.message.Message.get_payload if you pass it the proper arguments -- http://docs.python.org/2/library/email.message.html#email.message.Message.get_payload -- good catch, though; I should definitely be decoding the payload components.
coddingtonbear
added a commit
that referenced
this pull request
Jul 27, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g.:
echo "Hello there" | mail test@yourdomain.com
would result into a missing email subject.
Needs some rework for get_filename() method.
Not tested most of the changes by @Anders.Du : addresses, filename parsing updates and getitem removal.
What works well:
subject parsing, text body parsing, missing fields fixes.