feat(nx-plugin): adjust bin path handling#1109
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit f8c425a
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 695acbc ☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
13 tasks
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit 970a665 with previous commit f335d20. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 3 audits improved, 👎 2 audits regressed, 16 audits changed without impacting score🗃️ Groups
18 other groups are unchanged. 🛡️ Audits
589 other audits are unchanged. |
added 10 commits
October 4, 2025 17:14
# Conflicts: # e2e/nx-plugin-e2e/tests/plugin-create-nodes.e2e.test.ts
matejchalk
reviewed
Oct 23, 2025
packages/nx-plugin/src/plugin/target/executor.target.unit.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
…code' into feat/plugin-nx/allow-unreleased-code
matejchalk
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precondition:
This PR includes:
cliproject'nx-pluginprojects executors (not the target inference)Note
After this is merged is should be possible to use it locally like this:
_nx.json.defaultTargets
or
nx.json.plugins
{ "plugin": "@code-pushup/nx-plugin", "options": { "bin": "./packages/cli/dist", "env": { "NODE_OPTIONS": "--import tsx", "TSX_TSCONFIG_PATH": "tsconfig.base.json" } } }Then run:
nx code-pushupYou will see a log that prints the executed command as copy past version for you to re-ensure the setup.
NODE_OPTIONS="--import tsx" TSX_TSCONFIG_PATH="tsconfig.base.json" npx @code-pushup/cli --verbose --no-progress --config="code-pushup.config.ts" --upload.project="cli-workspace"The only thing that is left but blocked by Nx, is using the local target inference code with external dependencies.
Another precondition of: