refactor: add sync generator for zod2md tooling setup#1188
refactor: add sync generator for zod2md tooling setup#1188
Conversation
|
View your CI Pipeline Execution ↗ for commit a9e4878
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 58b3eea ☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit d2b985c with previous commit 3137af7. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 89 | 🟡 89 |
5 other categories are unchanged.
👎 1 group regressed, 👎 2 audits regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 89 | 🟡 89 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Line coverage | 🟩 95.5 % | 🟩 94.7 % | |
| Code coverage | Branch coverage | 🟨 81.4 % | 🟨 80.8 % |
442 other audits are unchanged.
💼 Project utils
🥳 Code PushUp report has improved.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 95 | 🟢 95 | |
| Documentation | 🟡 61 | 🟡 61 |
4 other categories are unchanged.
👍 2 groups improved, 👍 1 audit improved
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 95 | 🟢 95 | |
| JSDocs coverage | Documentation coverage | 🟡 61 | 🟡 61 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟩 91.9 % | 🟩 91.9 % |
443 other audits are unchanged.
💼 Project plugin-lighthouse
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
All of 6 categories are unchanged.
1 audit changed without impacting score
🗃️ Groups
All of 15 groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟩 98.8 % | 🟩 98.8 % |
443 other audits are unchanged.
11 other projects are unchanged.
# Conflicts: # nx.json # package-lock.json # tools/zod2md-jsdocs/project.json
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit d2b985c with previous commit 3137af7. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 1 group regressed, 👍 4 audits improved, 👎 4 audits regressed, 13 audits changed without impacting score🗃️ Groups
32 other groups are unchanged. 🛡️ Audits
658 other audits are unchanged. |
# Conflicts: # tools/zod2md-jsdocs/tsconfig.json # tools/zod2md-jsdocs/tsconfig.lib.json # tools/zod2md-jsdocs/tsconfig.test.json
# Conflicts: # testing/test-utils/src/index.ts
- Fix path.join issue with absolute paths starting with '/' - This resolves nx workspace root detection issues on Windows
|
@matejchalk to be able to use uncompiled Nx tooling code we can't have Here we see the existing plugin does not have any import to local files: https://github.com/code-pushup/cli/blob/main/tools/zod2md-jsdocs/src/nx-plugin.ts otherwise it fails. Any other ideas? 💡 how should we progress here other than avoiding extensions? |
Removing import extensions would break our package builds. That's not worth it for a nice-to-have local tool. If there's no way to tell Nx to look up a matching |
💡 Actually, I think I've found a way. We can set a custom Node loader using environment variables. I've tested it locally by adding a |
I digged into this also. I did not use this in the current PR as suggested solution (sry to not mention it here!). Nx has Why SWC is skipped when running Nx with
|
|
I opened #1242 to address the local plugin problem in a separate PR. |
preconditions:
This PR implements:
zod2mddependencies ifzod2md.config.jsis presentUsage
Example project structure
Targeted behavior summary
zod2md.config.ts→ project is ignoredbuild.dependsOnentries → updated automatically