Skip to content

refactor: simplify trace types and helper#1236

Open
BioPhoton wants to merge 19 commits intomainfrom
feat/utils/revamp-trace-types
Open

refactor: simplify trace types and helper#1236
BioPhoton wants to merge 19 commits intomainfrom
feat/utils/revamp-trace-types

Conversation

@BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Feb 3, 2026

Related:

This PR includes:

  • simper tract event types
  • fixed detail structure
  • renamed helper
  • added unique id helper

Followup:

@nx-cloud
Copy link

nx-cloud bot commented Feb 3, 2026

View your CI Pipeline Execution ↗ for commit 43b9540

Command Status Duration Result
nx run-many --targets=code-pushup --parallel=fa... ❌ Failed 13m 3s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 12s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-08 13:14:19 UTC

@nx-cloud
Copy link

nx-cloud bot commented Feb 3, 2026

View your CI Pipeline Execution ↗ for commit ad83c42

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 6s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 33s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 13m 39s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 1m 16s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-03 16:16:42 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 3, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1236

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1236

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1236

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1236

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1236

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1236

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1236

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1236

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1236

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1236

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1236

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1236

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1236

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1236

commit: 43b9540

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 6b6379d with previous commit 3dbf378.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Updates 🟡 78 🟡 75 ↓ −3.1
Performance 🔴 37 🔴 38 ↑ +0.8
Documentation 🟡 53 🟡 53 ↓ −0.2
Bug prevention 🟡 75 🟡 75 ↓ −0.2
Code coverage 🟢 93 🟢 93 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 100 🟢 100
Security 🔴 47 🔴 47
Type Safety 🟡 67 🟡 67
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 4 groups regressed, 👍 3 audits improved, 👎 7 audits regressed, 18 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JS packages npm outdated dependencies 🟡 78 🟡 75 ↓ −3.1
Lighthouse Performance 🔴 37 🔴 38 ↑ +0.8
ESLint Problems 🟢 100 🟢 99 ↓ −0.7
JSDocs coverage Documentation coverage 🟡 53 🟡 53 ↓ −0.2
Code coverage Code coverage metrics 🟢 93 🟢 93 ↓ −0.1

29 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
ESLint disallow unsupported Node.js built-in APIs on the specified version 🟩 passed 🟥 1 error ↑ +∞ %
Lighthouse Minify CSS 🟨 Potential savings of 10 KiB 🟩 0  −∞ %
Lighthouse First Contentful Paint 🟥 3.5 s 🟥 3.2 s ↓ −8.4 %
JS packages Outdated npm prod dependencies. 🟨 20 outdated package versions (5 major, 11 minor, 4 patch) 🟨 20 outdated package versions (6 major, 10 minor, 4 patch)  +0 %
JSDocs coverage Types coverage 🟥 264 undocumented types 🟥 264 undocumented types  +0 %
JSDocs coverage Variables coverage 🟥 274 undocumented variables 🟥 273 undocumented variables ↓ −0.4 %
JSDocs coverage Functions coverage 🟥 585 undocumented functions 🟥 585 undocumented functions  +0 %
JSDocs coverage Properties coverage 🟥 42 undocumented properties 🟥 43 undocumented properties ↑ +2.4 %
Code coverage Branch coverage 🟨 89.2 % 🟨 89.1 % ↓ −0.1 %
Code coverage Line coverage 🟩 92.8 % 🟩 92.8 % ↓ −0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,119 KiB 🟩 Total size was 2,085 KiB ↓ −1.6 %
Lighthouse Server Backend Latencies 🟩 1,220 ms 🟩 280 ms ↓ −76.9 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↓ −0.1 %
Lighthouse Largest Contentful Paint 🟥 12.3 s 🟥 11.8 s ↓ −4.6 %
Lighthouse Minimizes main-thread work 🟥 10.2 s 🟥 9.9 s ↓ −3.3 %
Lighthouse Max Potential First Input Delay 🟥 1,080 ms 🟥 990 ms ↓ −7.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +0.5 %
Lighthouse Time to Interactive 🟥 13.4 s 🟥 13.5 s ↑ +0.5 %
Lighthouse JavaScript execution time 🟥 3.2 s 🟥 3.1 s ↓ −2.2 %
Lighthouse Initial server response time was short 🟩 Root document took 560 ms 🟩 Root document took 500 ms ↓ −10.3 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 225 KiB 🟥 Potential savings of 225 KiB ↑ +4.8 %
Lighthouse Speed Index 🟥 7.3 s 🟥 7.4 s ↑ +0.5 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 146 KiB 🟥 Potential savings of 111 KiB ↑ +5 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 91 KiB 🟥 Potential savings of 93 KiB ↑ +4.4 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 60 ms ↓ −14.2 %
TypeScript Semantic errors 🟥 43 errors 🟥 36 errors ↓ −16.3 %
Lighthouse Total Blocking Time 🟥 1,310 ms 🟥 1,310 ms ↑ +0.4 %
JS packages Vulnerabilities for npm dev dependencies. 🟥 47 vulnerabilities (3 critical, 9 high, 32 moderate, 3 low) 🟥 48 vulnerabilities (3 critical, 9 high, 32 moderate, 4 low) ↑ +2.1 %

651 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit b103f50 with previous commit 7b6e72c.

💼 Project plugin-axe

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 70 🟡 70 ↑ +0.2
Code coverage 🟢 94 🟢 94 ↑ +0.1

4 other categories are unchanged.

👍 2 groups improved, 👍 3 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 70 🟡 70 ↑ +0.2
Code coverage Code coverage metrics 🟢 94 🟢 94 ↑ +0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Functions coverage 🟨 12 undocumented functions 🟨 12 undocumented functions  +0 %
Code coverage Branch coverage 🟩 90 % 🟩 90.3 % ↑ +0.3 %
Code coverage Line coverage 🟨 73 % 🟨 73.2 % ↑ +0.3 %

440 other audits are unchanged.

💼 Project utils

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 61 🟡 60 ↓ −0.1
Code coverage 🟢 95 🟢 95 ↓ −0.1

4 other categories are unchanged.

👎 2 groups regressed, 👍 2 audits improved, 👎 4 audits regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDocs coverage Documentation coverage 🟡 61 🟡 60 ↓ −0.1
Code coverage Code coverage metrics 🟢 95 🟢 95 ↓ −0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Variables coverage 🟥 50 undocumented variables 🟥 49 undocumented variables ↓ −2 %
JSDocs coverage Types coverage 🟨 55 undocumented types 🟨 55 undocumented types  +0 %
JSDocs coverage Functions coverage 🟥 243 undocumented functions 🟥 243 undocumented functions  +0 %
JSDocs coverage Properties coverage 🟥 39 undocumented properties 🟥 40 undocumented properties ↑ +2.6 %
Code coverage Branch coverage 🟩 91.9 % 🟩 91.8 % ↓ −0.1 %
Code coverage Line coverage 🟩 97.8 % 🟩 97.8 % ↑ +0.1 %

438 other audits are unchanged.

💼 Project core

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 90 🟢 90 ↑ +0.1

5 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 83.2 % 🟨 83.3 % ↑ +0.2 %
Code coverage Line coverage 🟩 94.8 % 🟩 94.8 % ↑ +0.1 %

442 other audits are unchanged.

💼 Project ci

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 92 🟢 92 ↓ −0.1

5 other categories are unchanged.

👎 1 group regressed, 👍 1 audit improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 92 🟢 92 ↓ −0.1

14 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟨 83.6 % 🟨 83.5 % ↓ −0.1 %
Code coverage Line coverage 🟩 94.8 % 🟩 94.8 % ↑ +0.1 %

443 other audits are unchanged.


10 other projects are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review February 3, 2026 16:18
BioPhoton and others added 9 commits February 3, 2026 21:48
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
Co-authored-by: Hanna Skryl <80118140+hanna-skryl@users.noreply.github.com>
@BioPhoton BioPhoton requested a review from hanna-skryl February 3, 2026 21:47
@BioPhoton BioPhoton enabled auto-merge (squash) February 3, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants