Skip to content

Conversation

@JonasScholl
Copy link
Member

The first thing I recognised when using this package was that you don't get a proper error when the database URI is None. So I started just by adding type checks, but then I saw we could improve a bit more (seems like I'm not that good at code reviews at night in the train...)

So that's what I basically did:

  • added type checks for input arguments
  • restructured integration tests & added ones just for the database (besides the fastapi ones)
  • the unit tests weren't really unit tests (they actually used the db) -> changed them to unit tests using mockito
  • made the singletons argument-specific - for the case that you have multiple database configurations

@JonasScholl JonasScholl changed the title QOL & test improvements QoL & test improvements Dec 11, 2022
@JonasScholl JonasScholl changed the title QoL & test improvements QOL & test improvements Dec 11, 2022
@JonasScholl JonasScholl self-assigned this Dec 11, 2022
Copy link
Contributor

@yannicschroeer yannicschroeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A lot of useful improvements

@JonasScholl JonasScholl merged commit 744fa92 into main Dec 11, 2022
@JonasScholl JonasScholl deleted the quality-improvements branch December 11, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants