Enhance global exception handling by implementing ProblemDetail

[codebyNorthsteep]

This pull request updates the global exception handling in the application to use Spring's standardized ProblemDetail response format for API errors, replacing the custom ApiErrorResponse class. This change ensures more consistent and structured error responses across the API, and leverages built-in Spring features for error reporting.

Key changes include:

Exception Handling Modernization:

• Replaced the custom ApiErrorResponse class with Spring's ProblemDetail for all error responses, standardizing the error format and including additional metadata such as a timestamp and error title. (GlobalExceptionHandler.java, ApiErrorResponse.java) [1] [2]
• Enhanced error responses by adding a timestamp property and descriptive titles for different types of errors (e.g., "LLM Error", "Connection Timeout", "Validation Error", "Malformed Request", "Internal Server Error"). (GlobalExceptionHandler.java)

Configuration Update:

• Enabled support for Problem Details in Spring MVC by setting spring.mvc.problemdetails.enabled=true in the application configuration. (application.properties)

These changes improve the API's error reporting, making it easier for clients to understand and handle errors.…nses for various exceptions and enabling detailed error reporting

Summary by CodeRabbit

• Refactor
  • Refactored error response handling to use standardized Spring error response format for improved consistency and better compatibility across API tools and clients.

[coderabbitai]

Warning

Rate limit exceeded

@codebyNorthsteep has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 53 minutes and 42 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 771ccf99-d8e1-4980-a797-d0d379edf1f4

📥 Commits

Reviewing files that changed from the base of the PR and between bdd800c and bed1032.

📒 Files selected for processing (1)

• src/main/java/org/example/projectbifrost/exception/GlobalExceptionHandler.java

📝 Walkthrough

Walkthrough

The pull request migrates exception response handling from a custom ApiErrorResponse record to Spring's native ProblemDetail type. Configuration enables Spring MVC Problem Details support, GlobalExceptionHandler is refactored to construct ProblemDetail responses with timestamp properties and standardized titles for all exception types, and the custom ApiErrorResponse record is removed as obsolete.

Changes

Spring ProblemDetail Migration

Layer / File(s)	Summary
Configuration src/main/resources/application.properties	Spring MVC Problem Details support is enabled via spring.mvc.problemdetails.enabled=true.
Exception Handler Refactoring src/main/java/org/example/projectbifrost/exception/GlobalExceptionHandler.java	All five exception handlers (handleLLMException, handleTimeoutException, handleValidationException, handleUnreadableMessage, handleGeneralException) are updated to return ResponseEntity<ProblemDetail> instead of ResponseEntity<ApiErrorResponse>. Each handler now constructs a ProblemDetail with a timestamp property set to Instant.now().toString(), assigns a standardized title, and applies the appropriate HTTP status code. Imports are updated to include ProblemDetail and Instant.
Deprecated Record Removal src/main/java/org/example/projectbifrost/exception/ApiErrorResponse.java	The custom ApiErrorResponse record is removed, as ProblemDetail replaces its functionality.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• codebyNorthsteep/ProjectBifrost#3: Both PRs modify exception-handling components—directly modifying GlobalExceptionHandler and ApiErrorResponse at the code level.

Poem

🐰 ✨ The errors now speak Spring's native tongue,
With ProblemDetails and timestamps sung.
Old ApiErrorResponse bids farewell with grace,
As standardized responses take its place! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change—replacing custom ApiErrorResponse with Spring's ProblemDetail for improved exception handling.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch enhancement/replaceApiResponse

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/main/java/org/example/projectbifrost/exception/GlobalExceptionHandler.java`:
- Around line 72-78: In the ErrorResponse branch inside GlobalExceptionHandler,
the ProblemDetail created by ProblemDetail.forStatusAndDetail(status, message)
lacks a title which makes responses inconsistent; update that branch to call
problem.setTitle(...) (preferably using a title from the ErrorResponse instance,
e.g., er.getTitle() or a sensible default like "Error") after creating the
ProblemDetail and before returning, keeping the existing timestamp property
(TIMESTAMP_PROPERTY) and status handling intact.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 83fb28a4-e1a7-4468-bc01-b88b7604ec2c

📥 Commits

Reviewing files that changed from the base of the PR and between 90e79a5 and bdd800c.

📒 Files selected for processing (3)

• src/main/java/org/example/projectbifrost/exception/ApiErrorResponse.java
• src/main/java/org/example/projectbifrost/exception/GlobalExceptionHandler.java
• src/main/resources/application.properties

💤 Files with no reviewable changes (1)

• src/main/java/org/example/projectbifrost/exception/ApiErrorResponse.java