Failing before each hook does exit with code 0

[philipstanislaus]

While failing tests exit with an exit code > 0, a failing before each hook does exit with code 0 when it fails. Here is an example:

Consequently, CI tests can fail without the CI tool noticing it.

[DavertMik]

Thanks! Good report

[DavertMik]

Tests are running!
CodeceptJS v0.4.8
Using test root "/home/davert/projects/codeceptjs/examples"

GitHub --
 ✖ "before each" hook: Before for "search" in 3135ms

-- FAILURES:

  1) GitHub "before each" hook: Before for "search":
     unknown error: unhandled inspector error: {"code":-32603,"message":"Cannot navigate to invalid URL"}

  Run with --verbose flag to see NodeJS stacktrace


  FAIL  | 0 passed, 1 failed   // 3s
➜  codeceptjs git:(master) ✗ echo $?                                      
1

this is in master branch and will be in 0.4.9

[philipstanislaus]

Great, many thanks! 👍