fix: TestCafe grabAttributeFrom method not works by elukoyanov · Pull Request #2064 · codeceptjs/CodeceptJS

elukoyanov · 2019-12-04T15:32:12Z

Motivation/Description of the PR

Applicable helpers:

Webdriver
Puppeteer
Nightmare
REST
Appium
Protractor
TestCafe
Description of this PR, which problem it solves
grabAttributeFrom() method not returning the attribute value
A link to the corresponding issue (if applicable).
https://stackoverflow.com/questions/59133688/grabattributefrom-method-not-returning-the-attribute-value

Type of change

Checklist:

Tests have been added
Documentation has been added (Run npm run docs)
Lint checking (Run npm run lint)
Local tests are passed (Run npm test)

DavertMik · 2019-12-04T23:49:26Z

Seems fine, but test failed

elukoyanov · 2019-12-05T11:19:49Z

Don't understand, why travis build for TestCafe fails every time with catched error from previous test
Locally all builds ><

And why circle-ci with webdriver fails

elukoyanov · 2019-12-05T13:44:55Z

Skipped some failing tests for TestCafe.

But somewhy Webdriverio tests fails in Circle CI, does not know why.

elukoyanov · 2019-12-05T13:47:21Z

Looks like we have a problem with test. Cause if some test in test suite thows error (and catches it), then all next tests fails

elukoyanov · 2019-12-06T09:52:55Z

webdriverio v5.16.12 was released between first (passed) and second (failed) circle CI builds.

https://github.com/webdriverio/webdriverio/releases

DavertMik · 2019-12-06T15:40:23Z

Here is an overview of what got changed by this pull request:

Clones added
============
- test/helper/webapi.js  4

See the complete overview on Codacy

* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * try to shorten the test execution time * Update package.json * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>

* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * add I.say() to allure * Remove I say Co-Authored-By: Michael Bodnarchuk <DavertMik@users.noreply.github.com> Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com> Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>

* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * fix the ambiguous description * CR fix Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>

…#2140) * Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * some improvements * improve the way to get uuid * move private func to the end * mocha update is not here Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>

* Streamlined return values from grab* (#2054) * fix: replace console.print with console.log Since `console.print()` does not exists 😄 * File system extended (#2034) * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * check file exists with given substring * tests are added * deleted trailing-space * removed spaces * compatibility for node 8 * assertion message fixed * get changed into grab * Examples added * trailing spaces * fix: cannot grab for css attributes with hyphen (#2059) * Docs/remove jsdoc extra line (#2068) * docs: remove prepending line in JSDoc generator * definitions: update generated types * fix: TestCafe grabAttributeFrom method not works (#2064) * fix: testcafe grabAttributeFrom * test: make skippable tests use mocha's skip * fix: TestCafe.grabValueFrom * build: add eslintignore for test output * test: unskip working TestCafe tests * test: remove skip form Nightmare tests * tests: skip testcafe webapi tests * tests: fix skips * #1911 - Regex for step Def file (#2043) * #1911 - Regex for step Def file * #1911 : Regex for step Def file,Fixed hound reviews * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 : Regex for step Def file,Fixed hound reviews - 1 * #1911 - Removing commented lines of code * #1911 - Modifying so that decision is based on Array or not * #1911 - Fixing Hound reviews * #1911 - Amending for code review * #1911 - Amending for code review - 3 * Allows overriding default Polly config in MockRequest (#2060) * Add Interoperable Code for supporting both CJS & ESM environments (#2075) * Added Interoperable Code Add Interoperable Code to support both CJS and ESM environments. * Linter Fixes * fix(docs): add info about _after hook in helper * (fix): no custom output folder is created with run-worker * CR fix * verify the output folder is created Co-authored-by: Richard Petersen <Holorium@users.noreply.github.com> Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> Co-authored-by: Ahmed Yılmaz <ahmet6yilmaz@gmail.com> Co-authored-by: Evgeniy Lukoyanov <11647141+elukoyanov@users.noreply.github.com> Co-authored-by: Srivatsan <vatsan34@gmail.com> Co-authored-by: Daniel Eckermann <danieleckermann@gmail.com> Co-authored-by: K.C.Ashish Kumar <kcak11@gmail.com> Co-authored-by: Alexandr Vorobey <sashavorobey95@gmail.com>

fix: testcafe grabAttributeFrom

c3a50e6

elukoyanov added ready for review testcafe and removed ready for review labels Dec 4, 2019

elukoyanov added 5 commits December 5, 2019 12:30

test: make skippable tests use mocha's skip

43e161a

fix: TestCafe.grabValueFrom

0651945

build: add eslintignore for test output

bd9354b

test: unskip working TestCafe tests

362922e

test: remove skip form Nightmare tests

ea9de4d

elukoyanov added the ready for review label Dec 5, 2019

DavertMik previously approved these changes Dec 6, 2019

View reviewed changes

elukoyanov requested review from Vorobeyko, kobenguyent and pablopaul December 6, 2019 11:37

elukoyanov dismissed DavertMik’s stale review via e3ed1aa December 6, 2019 13:46

elukoyanov force-pushed the fix/testcafe-grabattributefrom branch from e3ed1aa to ea9de4d Compare December 6, 2019 14:21

elukoyanov added 2 commits December 6, 2019 17:56

tests: skip testcafe webapi tests

c0cd3d6

tests: fix skips

df7fe50

DavertMik approved these changes Dec 6, 2019

View reviewed changes

Vorobeyko approved these changes Dec 8, 2019

View reviewed changes

Vorobeyko merged commit d2be52c into codeceptjs:master Dec 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: TestCafe grabAttributeFrom method not works#2064

fix: TestCafe grabAttributeFrom method not works#2064
Vorobeyko merged 8 commits into
codeceptjs:masterfrom
elukoyanov:fix/testcafe-grabattributefrom

elukoyanov commented Dec 4, 2019

Uh oh!

DavertMik commented Dec 4, 2019

Uh oh!

elukoyanov commented Dec 5, 2019 •

edited

Loading

Uh oh!

elukoyanov commented Dec 5, 2019

Uh oh!

elukoyanov commented Dec 5, 2019

Uh oh!

elukoyanov commented Dec 6, 2019

Uh oh!

DavertMik commented Dec 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

elukoyanov commented Dec 4, 2019

Motivation/Description of the PR

Type of change

Checklist:

Uh oh!

DavertMik commented Dec 4, 2019

Uh oh!

elukoyanov commented Dec 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elukoyanov commented Dec 5, 2019

Uh oh!

elukoyanov commented Dec 5, 2019

Uh oh!

elukoyanov commented Dec 6, 2019

Uh oh!

DavertMik commented Dec 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

elukoyanov commented Dec 5, 2019 •

edited

Loading