fix: Avoid failiure report on successful retry in worker#2141
Merged
Conversation
KMKoushik
requested review from
DavertMik,
kobenguyent,
pablopaul and
puneet0191
KMKoushik
force-pushed
the
koushik-worker-fix
branch
from
cb2fa58 to
e3fd846
Compare
Contributor
|
Complexity increasing per file
==============================
- test/data/sandbox/workers/retry_test.workers.js 1
See the complete overview on Codacy |
10 tasks
DavertMik
approved these changes
Jan 16, 2020
kobenguyent
reviewed
Jan 17, 2020
4 tasks
puneet0191
approved these changes
Jan 18, 2020
Contributor
|
@koushikmohan1996 is that compatible with your PR with the refactoring of workers? |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Tests are not reported as passed if the test is passed in a retry while using run-workers.
While appending test status, passing of already failed test is not accounted for. So adding a map with
test.idand appending status accordingly fixes the issue.Type of change
Checklist:
npm run docs)npm run lint)npm test)