Skip to content

fix: session typing - #3899

Merged
kobenguyent merged 2 commits into
3.xfrom
fix-session-typings
Oct 6, 2023
Merged

fix: session typing#3899
kobenguyent merged 2 commits into
3.xfrom
fix-session-typings

Conversation

@kobenguyent

Copy link
Copy Markdown
Collaborator

Motivation/Description of the PR

  • Most of the time, we are using session without returning anything so this PR to get rid of complaining when using session without await.

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent added the typescript Changes for typings or typescript compatibility label Sep 28, 2023
@kobenguyent
kobenguyent merged commit 3358929 into 3.x Oct 6, 2023
@kobenguyent
kobenguyent deleted the fix-session-typings branch October 6, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typescript Changes for typings or typescript compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants