Skip to content

fix: rename haveRequestHeaders of ppt and pw helpers - #3937

Merged
kobenguyent merged 4 commits into
3.xfrom
3630-using-haverequestheaders-rest-playwright
Oct 28, 2023
Merged

fix: rename haveRequestHeaders of ppt and pw helpers#3937
kobenguyent merged 4 commits into
3.xfrom
3630-using-haverequestheaders-rest-playwright

Conversation

@kobenguyent

Copy link
Copy Markdown
Collaborator

Motivation/Description of the PR

Renamed haveRequestHeaders of PPT, PW helper so that it would not confuse the REST helper.
PPT: setPuppeteerRequestHeaders
PW: setPlaywrightRequestHeaders

Applicable helpers:

  • Playwright
  • Puppeteer

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
kobenguyent merged commit f78c027 into 3.x Oct 28, 2023
@kobenguyent
kobenguyent deleted the 3630-using-haverequestheaders-rest-playwright branch October 28, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using haveRequestHeaders (REST, Playwright)

2 participants