Skip to content

fix: AppiumTestDistribution/appium-device-farm requires 'platformName' - #3950

Merged
kobenguyent merged 1 commit into
codeceptjs:3.xfrom
mobile-health:feature/3.x_appium_device_farm
Oct 28, 2023
Merged

fix: AppiumTestDistribution/appium-device-farm requires 'platformName'#3950
kobenguyent merged 1 commit into
codeceptjs:3.xfrom
mobile-health:feature/3.x_appium_device_farm

Conversation

@rock-tran

Copy link
Copy Markdown
Contributor

Motivation/Description of the PR

  • Description of this PR, which problem it solves

I'm trying to run tests with Appium + it's plugin DeviceFarm.
At the start, the plugin raises the error then I realize it requires the 'platformName' in the capabilities.
I know I may update such plugins ( include AppiumDashboard) but that key is used so many places.
Send duplicated capabilities is easier way to fix it.

  • Resolves #issueId (if applicable).

Applicable helpers:

  • Appium

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • [] 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent

Copy link
Copy Markdown
Collaborator

I guess this one just clone more key values, and won't break anything. Thanks @rock-tran

@kobenguyent
kobenguyent merged commit e590213 into codeceptjs:3.x Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants