fix(workers): event improvements - #3953
Merged
Merged
Conversation
DavertMik
requested changes
Oct 28, 2023
DavertMik
left a comment
Contributor
There was a problem hiding this comment.
Sorry, I don't think we can accept this implementation
This will cause extra side effects from main thread like starting/closing browsers, which is not required there
This was referenced Oct 31, 2023
Arhell
approved these changes
Nov 3, 2023
Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>
Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>
Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>
Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>
kobenguyent
force-pushed
the
worker-event-improvements
branch
from
November 7, 2023 09:04
d063310 to
8c2212b
Compare
|
@DavertMik can you please re-check changes ? |
|
@DavertMik can you please review? Need this changes/fixes |
DavertMik
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
workers.resulteventCodeceptJS also exposes the env var
process.env.RUNS_WITH_WORKERSwhen running tests withrun-workerscommand so that you could handle the events better in your plugins/helpersType of change
Checklist:
npm run docs)npm run lint)npm test)