Skip to content

fix(ci): project-sync should not fail when merged PR has no closing keyword #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajianaz merged 1 commit into from
Jul 16, 2026
Merged

fix(ci): project-sync should not fail when merged PR has no closing keyword #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/project-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,10 @@ jobs:
| python3 -c "
import sys, json
data = json.load(sys.stdin)
node = (data.get('data') or {}).get('node') or {}
items = (node.get('items') or {}).get('nodes') or []
target = '$content_node_id'
for n in data['data']['node']['items']['nodes']:
for n in items:
c = n.get('content') or {}
if c.get('id') == target:
print(n['id'])
Expand Down Expand Up @@ -176,17 +178,21 @@ jobs:
| python3 -c "
import sys, json
data = json.load(sys.stdin)
nodes = data['data']['node']['closingIssuesReferences']['nodes']
node = (data.get('data') or {}).get('node') or {}
nodes = (node.get('closingIssuesReferences') or {}).get('nodes') or []
for n in nodes:
print(n['id'] + ' ' + str(n['number']))
" 2>/dev/null || true)

if [ -z "$LINKED" ]; then
echo "No linked closing issues found for PR #$PR_NUMBER."
# If the PR content itself is on the board, mark it Done.
item_id=$(get_item_id "$PR_NODE_ID")
# A merged PR that references issues via "Refs #N" (rather than
# a closing keyword) legitimately has no closing references —
# this is not an error. Best-effort: mark the PR itself Done if
# it happens to be on the board.
item_id=$(get_item_id "$PR_NODE_ID" || true)
if [ -n "$item_id" ]; then
set_done "$item_id"
set_done "$item_id" || true
fi
else
echo "$LINKED" | while read -r issue_node issue_num; do
Expand Down
Loading