Skip to content

perf: remove unused deps + replace deprecated serde_yaml #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajianaz merged 2 commits into from
May 30, 2026
Merged

perf: remove unused deps + replace deprecated serde_yaml #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee822fb
perf: remove unused deps + replace deprecated serde_yaml
May 30, 2026
7696ef7
fix: replace serde_yml (deprecated) with serde_yaml_ng
May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 4 additions & 177 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 3 additions & 6 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,22 @@ rust-version = "1.85"
clap = { version = "4", features = ["derive", "env"] }
clap_complete = "4"

# Async runtime
tokio = { version = "1", features = ["full"] }
# Async runtime (only what we need)
tokio = { version = "1", features = ["rt-multi-thread", "macros"] }

# HTTP client (OpenAI-compatible API calls)
reqwest = { version = "0.12", features = ["json", "stream", "rustls-tls"], default-features = false }

# Serialization
serde = { version = "1", features = ["derive"] }
serde_json = "1"
serde_yaml = "0.9"
serde_yaml_ng = "0.10"

# Git operations
git2 = { version = "0.20", default-features = false, features = ["vendored-libgit2"] }

# Terminal output
colored = "3"
owo-colors = "4"
indicatif = "0.18"

# File system
Expand All @@ -41,7 +40,6 @@ walkdir = "2"

# Error handling
anyhow = "1"
thiserror = "2"

# Config
toml = "0.8"
Expand All @@ -51,7 +49,6 @@ tracing = "0.1"
tracing-subscriber = { version = "0.3", features = ["env-filter"] }

# Misc
chrono = "0.4"
regex = "1"
futures-util = "0.3"

Expand Down
6 changes: 3 additions & 3 deletions src/config/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ pub struct OutputSection {

impl CoraFile {
pub fn from_str(content: &str) -> Result<Self> {
serde_yaml::from_str(content).context("failed to parse .cora.yaml")
serde_yaml_ng::from_str(content).context("failed to parse .cora.yaml")
}

/// Merge this file config into a `Config`, overwriting only fields that are present.
Expand Down Expand Up @@ -433,8 +433,8 @@ output:
focus: Some(vec!["security".to_string()]),
..Default::default()
};
let yaml = serde_yaml::to_string(&cora).unwrap();
let back: CoraFile = serde_yaml::from_str(&yaml).unwrap();
let yaml = serde_yaml_ng::to_string(&cora).unwrap();
let back: CoraFile = serde_yaml_ng::from_str(&yaml).unwrap();
assert_eq!(
back.provider.as_ref().unwrap().provider.as_deref(),
Some("ollama")
Expand Down
Loading
Loading