docs: fix all documentation issues#57
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughCONTRIBUTING.md and README.md documentation updated to reflect Rust 1.85+ toolchain requirement, refined project structure, new CLI command patterns (cora init, cora review, cora scan), restructured .cora.yaml configuration schema, corrected CORA_* environment variable naming, and revised CI/CD integration guidance for GitHub Actions and GitLab CI. ChangesDocumentation Updates for cora-cli Requirements and CLI Patterns
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…e) (#342) Resolves the P3-core items from #334 — config values and profile values were accepted without semantic checks, so typos and out-of-range values propagated silently to runtime. #94 — Config::validate() at load time: - temperature 0.0..=2.0, max_tokens/timeout >= 1 - max_tokens_param, response_format, output.format, hook.mode/on_violation/min_severity - provider.base_url must have an http(s)/ws/unix scheme - multiple errors aggregated into one message #81 — Profile::validate(): focus weight 1-10, recognized action/tone/detail_level #57 — CategoryAction enum (case-insensitive deserialize): unknown values like 'blok' now fail loudly instead of silently becoming blocking #58 — evaluate() forces Pass when enabled=false (disabled gate never fails) #80 — deny_unknown_fields on all config sections: misspelled YAML keys (e.g. 'quailty_gate', 'temprature') rejected at parse time 24 new tests covering validation acceptance/rejection and deny_unknown_fields. All 637 tests pass; clippy + fmt clean. Refs #334
Summary
Fixes all documentation inaccuracies across README.md and CONTRIBUTING.md:
README.md (11 fixes)
cora config initCONTRIBUTING.md (4 fixes)
Summary by CodeRabbit
cora initcommand in Quick Start workflow.CORA_*naming convention.