fix: complete Uteke memory Phase 2+3 (#259)#260
Merged
Conversation
Phase 2 — Inject memory context into LLM prompt: - memory_context passed through execute_review → engine::review_diff - Appended to final_context before LLM call - Shows 'ℹ Review enriched with Uteke memory context.' when used Phase 3 — Extract real findings from ReviewResult: - ReviewResult extended with total_issues, severity_summary, categories - Helper methods: empty() for no-issue results, with_issues() for real data - save_findings() now receives actual counts/severities/categories - Shows '💾 Saved N findings to Uteke memory.' after --learn 506 tests pass, clippy clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259 — completes the Uteke memory integration from PR #256.
Phase 2 — Inject memory context into LLM prompt
memory_contextpassed throughexecute_review→engine::review_diff→final_contextℹ Review enriched with Uteke memory context.when usedPhase 3 — Extract real findings from ReviewResult
ReviewResultextended withtotal_issues,severity_summary,categoriesempty()for no-issue,with_issues()for real datasave_findings()now receives actual counts/severities/categories (was hardcoded 0)💾 Saved N findings to Uteke memory.after--learnTesting
--memoryand--learnflags