fix(#325): release workflow rewrite + roadmap + cleanup#326
Merged
Conversation
…refs (#325) Release workflow: - sync-main now tries fast-forward first, falls back to API force-update - sync-main is blocking again (removed continue-on-error) - build-release needs sync-main (was unblocked — root cause of #325) - Checkout uses tag commit directly (no ref: develop needed) Roadmap: - Added v0.0.13/14/15 sections (were missing) - Replaced speculative 'What's Next' with concrete v0.2.0 section - Consolidated older versions for readability Docs: - Fixed ajianaz → codecoradev in docs/launch/ posts - Fixed model path in architecture.md (models/embeddinggemma/ → embeddinggemma-q4/) - Fixed CHANGELOG historical website URL
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| # The tag points to a commit on develop. We want main to point | ||
| # to the exact same commit so install.sh (which fetches from main) | ||
| # always matches the release binary. |
🔍 Cora AI Code Review❌ Blocked — critical issues found. 🔴 Error (1)
if git merge-base --is-ancestor origin/main "$TAG_SHA" ...; then
git push origin "$TAG_SHA:refs/heads/main"
else
...
exit 1
fiThe surrounding comments still state that Review powered by cora-cli · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #325
Changes
Release workflow (
.github/workflows/release.yml)continue-on-error, build-release and publish-crates nowneeds: [sync-main]merge-base --is-ancestorbefore pushing. If main diverged, aborts with error instead of blind force-pushRoadmap (
docs/roadmap.md)Docs cleanup
docs/launch/: ajianaz → codecoradev (3 files)docs/architecture.md: model pathmodels/embeddinggemma/→embeddinggemma-q4/onnx/CHANGELOG.md: historical website URL updatedRoot cause of #325
Commit
20cb3e8made sync-maincontinue-on-error: true, so when it failed (main diverged from develop), builds proceeded anyway. The workflow fix makes sync-main blocking again — if main can't be fast-forwarded, the release aborts.Post-merge action
After this PR merges to develop, main needs to be fast-forwarded to develop HEAD. The next
v*tag push will auto-sync via the new workflow.