fix(core): robust embedding model download (#740)#744
Merged
Conversation
…ming (#740) - Add connect timeout (30s) and read timeout (300s) to prevent infinite hangs on slow/unstable connections - Retry up to 3 attempts on transient failures with cleanup - Stream download to disk via 64KB chunks instead of buffering entire 187MB model_data file in RAM - Add progress indicator (file size + percentage milestones) - Add human-readable byte formatting (KB/MB/GB) - Verify content-length matches downloaded bytes
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-cli · BYOK · MIT |
This was referenced Jul 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #740 — embedding model download fails on first run.
Problem
had several issues:
model_q4.onnx_datainto memory at onceChanges
Testing
cargo fmt✅cora review✅Closes #740