fix(worker): N+1 query in ProcessFlakesTask - #1013
Closed
sentry[bot] wants to merge 1 commit into
Closed
Conversation
Contributor
|
Closing as duplicate — Sentry Seer generated multiple PRs for the same issue. Keeping the newest/best candidate for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue within the
ProcessFlakesTaskinapp.tasks.flakes.ProcessFlakeTask. Root Cause: Previously,process_flakes_for_commitwould iterate through uploads and callprocess_single_uploadfor each. Insideprocess_single_upload,get_testruns(upload)would issue a separate database query forTestrunobjects for every single upload. This resulted in an N+1 query pattern where N is the number of uploads for a given commit. Additionally,handle_passwas callingflake.save()individually for each flake that reached its expiration criteria (30 recent passes), leading to excessive database writes within the processing loop. Changes Made: 1. Batch Testrun Fetching: A new functionget_testruns_for_uploadswas introduced to fetch allTestrunobjects for a list of uploads in a single, optimized database query.process_flakes_for_commitnow calls this function once and passes the relevant subset of testruns toprocess_single_upload. 2. Bulk Flake Expiration Updates: Thehandle_passfunction no longer callsflake.save(). Instead, expiring flakes are collected into a list (expiring_flakes). After all uploads have been processed,process_flakes_for_commitperforms a singleFlake.objects.bulk_updateoperation for all collected expiring flakes. These changes significantly reduce the number of database queries and writes, improving the performance of theProcessFlakesTask. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.Fixes WORKER-YPV