fix(graphql): restore deprecated changeWithParent field - #1875
Open
sentry[bot] wants to merge 1 commit into
Open
fix(graphql): restore deprecated changeWithParent field#1875sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 1332 1332
Lines 51830 51831 +1
Branches 1647 1647
=======================================
+ Hits 47598 47599 +1
Misses 3911 3911
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the
changeWithParentfield on theComparisonGraphQL type. An external client was encountering aGraphQLErrorbecause this field was removed in April 2023 (commit503dce5) during a cleanup of unused resolvers.To maintain backward compatibility and unblock the affected client, the
changeWithParentfield has been re-added to the schema, marked as@deprecated(reason: "UsechangeCoverage"). It aliases the existingresolve_change_coverageresolver, ensuring it provides the same functionality as before its removal. This approach resolves the immediate error while still signaling to clients that they should transition tochangeCoverage.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-ESN