Skip to content

fix(api): Remove BasicAuthentication to prevent AttributeError - #1883

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/api-9w4-remove-basic-auth
Open

fix(api): Remove BasicAuthentication to prevent AttributeError#1883
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/api-9w4-remove-basic-auth

Conversation

@sentry

@sentry sentry Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

This PR addresses issue API-9W4, where WrappedAttributeError: 'Manager' object has no attribute 'get_by_natural_key' was occurring on badge endpoints.

The error was triggered when requests to these endpoints included HTTP Basic Authentication headers. Django Rest Framework's BasicAuthentication class, which was enabled by default, would attempt to authenticate these requests by calling get_by_natural_key() on Codecov's custom User model manager. However, our custom User model manager does not implement this method, leading to the AttributeError.

Since Codecov does not utilize Basic Authentication (relying instead on Token and Session authentication), the rest_framework.authentication.BasicAuthentication class is unnecessary. This change removes it from the DEFAULT_AUTHENTICATION_CLASSES tuple in apps/codecov-api/codecov/settings_base.py, thereby eliminating the code path that caused the error.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes API-9W4

@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.83%. Comparing base (d8942db) to head (98043fa).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1883   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files        1332     1332           
  Lines       51830    51830           
  Branches     1647     1647           
=======================================
  Hits        47598    47598           
  Misses       3911     3911           
  Partials      321      321           
Flag Coverage Δ
apiunit 94.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codecov-notifications

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants