Ignore GitHub installation webhooks with a null account - #1887
Open
thomasrockhu-codecov wants to merge 4 commits into
Open
Ignore GitHub installation webhooks with a null account#1887thomasrockhu-codecov wants to merge 4 commits into
thomasrockhu-codecov wants to merge 4 commits into
Conversation
Returning 500 on these payloads feeds third-party redelivery loops; acknowledge them with a 200 and log the sending app id so we can identify the source. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Tracked in https://harness.atlassian.net/browse/COV-172 (subtask https://harness.atlassian.net/browse/COV-174). |
APITestCase is unittest-style, so pytest cannot inject the `mocker` fixture as a test method argument. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
calvin-codecov
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installation/installation_repositorieswebhook has a missing or nullinstallation.account, instead of crashing withTypeError(Sentry 7572921070).delivery,target_id(X-GitHub-Hook-Installation-Target-ID),app_id,installation_id, andactionso we can identify the sending GitHub App after deploy.Test plan
accountand missingaccounton bothinstallationandinstallation_repositoriesIgnoring installation webhook with missing accountand notetarget_idvaluesMade with Cursor