fix(worker): eliminate N+1 query in bundle analysis asset association - #1892
Open
sentry[bot] wants to merge 1 commit into
Open
fix(worker): eliminate N+1 query in bundle analysis asset association#1892sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1892 +/- ##
=======================================
Coverage 91.83% 91.83%
=======================================
Files 1332 1332
Lines 51830 51836 +6
Branches 1647 1646 -1
=======================================
+ Hits 47598 47604 +6
Misses 3911 3911
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an N+1 query performance issue in the
BundleAnalysisProcessortask, specifically within the_associate_bundle_report_assets_by_module_namesmethod.Problem:
Previously, when associating assets by module names, the code iterated over each asset and called
asset.modules()individually. Each call toasset.modules()opened a new database session and executed a separateSELECT modules...query. This resulted in an N+1 query pattern, where N is the number of assets in a bundle, leading to excessive database calls and performance degradation.Solution:
To resolve this, a new static method
_get_asset_module_names_bulkhas been introduced inBundleAnalysisReport. This method now performs a single, bulk SQL query to fetch all relevant(asset_uuid, module_name)pairs for all JavaScript assets within a given bundle report. The_associate_bundle_report_assets_by_module_namesmethod has been refactored to utilize this bulk-fetching mechanism. It now calls the bulk helper once for the previous bundle report and once for the current bundle report, then processes the data in memory.This change reduces the database query count from O(N) (where N is the number of assets) to a constant O(1) per bundle report comparison, significantly improving the performance of the bundle analysis process.
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-Z5J