This repository was archived by the owner on May 5, 2025. It is now read-only.
fix: update shared to include the logrecord error fix - #24
Merged
Conversation
matt-codecov
requested review from
giovanni-guidini,
joseph-sentry and
scott-codecov
July 21, 2023 16:56
giovanni-guidini
approved these changes
Jul 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 98.61% 98.61%
=======================================
Files 327 327
Lines 25192 25192
=======================================
Hits 24843 24843
Misses 349 349
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
tnt-sentry
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the other day worker pushed to production / enterprise instances. one instance had caching of certain github requests enabled and the cache decorator errored due to the issue fixed in codecov/shared#7.
this PR updates the shared ref to include the fix.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.