Does not work with parallel tests

[eladchen]

Hi,

I tried using this with parallel tests in junit5, and it seems that
the current codebase assumes a single thread..?

[jackmatt2]

https://github.com/origin-energy/java-snapshot-testing/blob/master/java-snapshot-testing-core/src/main/java/au/com/origin/snapshots/SnapshotMatcher.java#L15

Is meant to support this but maybe there is something else that needs to be ThreadLocal too.

[jackmatt2]

There appears to be a fundamental flaw in the library concerning parallel tests because all the snapshots are at class level.

I think 'junit.jupiter.testinstance.lifecycle.default': 'per_class' is the only way parallel will work.

test {
    useJUnitPlatform()
    systemProperties = [
            'junit.jupiter.execution.parallel.enabled': true,
            'junit.jupiter.execution.parallel.mode.default': 'concurrent',
            'junit.jupiter.testinstance.lifecycle.default': 'per_class'
    ]
}

OR

annotating your test class with @TestInstance

Can you try this parallel test configuration? I'm not too familiar with it, would be good to compare to your configuration.

[jackmatt2]

This is now fixed as part of the 3.0.0 Release.

[eladchen]

Hi glad to hear this was addressed.

Is there any specific API I'll need to use (with parallel testing)?

[jackmatt2]

Nope - The new api injects Expect expect into your test method so just use that.

The API has been refactored a little - take look at the quick start for an example. The snapshot format has not changed though so it should be backward compatible. It does require a mechanical refactor only.

I tested it with these in junit-platform.properties

junit.jupiter.execution.parallel.enabled=true
junit.jupiter.execution.parallel.mode.default=concurrent

[eladchen]

Cool. My only problem is having to add a parameter to every relevant test.

I'll try and find a solution to avoid that (maybe a base class or something)