Add IIR and remove redundant code#1080
Open
TheSecondComing123 wants to merge 1 commit into
Open
Conversation
hopefully this helps
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR tweaks the search algorithm by adding an Internal Iterative Reduction (IIR) condition in the main search and adjusting transposition table (TT) storage behavior in quiescence search.
Changes:
- Add an IIR depth reduction when no TT move exists at sufficient depth.
- Remove a conditional TT write in
qsearchbefore returningbest_score.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+738
to
+741
| // Internal Iterative Reductions (IIR) | ||
| if depth >= 4 && tt_move.is_null() && !excluded { | ||
| depth -= 1; | ||
| } |
Comment on lines
1268
to
1272
| best_score = lerp(best_score, beta, 0.8256); | ||
| } | ||
|
|
||
| if entry.is_none() { | ||
| td.shared.tt.write(hash, TtDepth::SOME, raw_eval, best_score, Bound::Lower, Move::NULL, ply, tt_pv, false); | ||
| } | ||
|
|
||
| return best_score; | ||
| } |
TheSecondComing123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully, this helps. Removed that part of the code because the write only came from a static eval without searching.
Bench: 1886322