Can't get Code Coverage

[kenjis]

$ phpunit --colors --coverage-text=coverage.txt --coverage-html=coverage/
PHPUnit 5.0.9 by Sebastian Bergmann and contributors.

...............................................................  63 / 145 ( 43%)
............................................................... 126 / 145 ( 86%)
...................                                             145 / 145 (100%)

Time: 11.14 seconds, Memory: 10.00Mb

OK (145 tests, 268 assertions)

Generating code coverage report in HTML format ...PHP Notice:  Constant CI_VERSION already defined in /mnt/project/system/CodeIgniter.php on line 17
PHP Stack trace:
PHP   1. {main}() /home/vagrant/.composer/vendor/phpunit/phpunit/phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() /home/vagrant/.composer/vendor/phpunit/phpunit/phpunit:47
PHP   3. PHPUnit_TextUI_Command->run() /home/vagrant/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php:105
PHP   4. PHPUnit_TextUI_TestRunner->doRun() /home/vagrant/.composer/vendor/phpunit/phpunit/src/TextUI/Command.php:154
PHP   5. PHP_CodeCoverage_Report_HTML->process() /home/vagrant/.composer/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:486
PHP   6. PHP_CodeCoverage->getReport() /home/vagrant/.composer/vendor/phpunit/php-code-coverage/src/CodeCoverage/Report/HTML.php:68
PHP   7. PHP_CodeCoverage_Report_Factory->create() /home/vagrant/.composer/vendor/phpunit/php-code-coverage/src/CodeCoverage.php:126
PHP   8. PHP_CodeCoverage->getData() /home/vagrant/.composer/vendor/phpunit/php-code-coverage/src/CodeCoverage/Report/Factory.php:24
PHP   9. PHP_CodeCoverage->addUncoveredFilesFromWhitelist() /home/vagrant/.composer/vendor/phpunit/php-code-coverage/src/CodeCoverage.php:160
PHP  10. PHP_CodeCoverage->processUncoveredFileFromWhitelist() /home/vagrant/.composer/vendor/phpunit/php-code-coverage/src/CodeCoverage.php:618
PHP  11. include_once() /home/vagrant/.composer/vendor/phpunit/php-code-coverage/src/CodeCoverage.php:645
PHP  12. define() /mnt/project/system/CodeIgniter.php:17

Notice: Constant CI_VERSION already defined in /mnt/project/system/CodeIgniter.php on line 17

[sv3tli0]

Come on.. you report issue on dev version of something which doesn't have Alpha version..

[lonnieezell]

To be honest - I've been waiting until a final PHP 7 is released to build a proper box. My current box doesn't have debug installed so haven't had a chance to test that yet. It will all happen in time. :)

[kenjis]

This error is because of processUncoveredFilesFromWhitelist="true", which is noted:

Please note that the loading of sourcecode files that is performed when processUncoveredFilesFromWhitelist="true" is set can cause problems when a sourcecode file contains code outside the scope of a class or function, for instance.
https://phpunit.de/manual/current/en/code-coverage-analysis.html#code-coverage-analysis.whitelisting-files

[kenjis]

I don't think we need processUncoveredFilesFromWhitelist="true".
See http://stackoverflow.com/questions/29041254/phpunit-coverage-what-is-the-difference-between-adduncoveredfilesfromwhitelist

We can get Code Coverage with the following diff:

--- a/phpunit.xml
+++ b/phpunit.xml
@@ -15,7 +15,7 @@
     </testsuites>

     <filter>
-        <whitelist processUncoveredFilesFromWhitelist="true">
+        <whitelist addUncoveredFilesFromWhitelist="true">
             <directory suffix=".php">./system</directory>
         </whitelist>
     </filter>

The default value of addUncoveredFilesFromWhitelist is true. So it is the same as just <whitelist>.

[lonnieezell]

Actually, that stackoverflow comment makes it sound like leaving it to the default processUncoveredFilesFromWhitelist=false is a faster method that is just as accurate when the answer is 0. So, it seems we can just do the whitelist tag without any attributes here.

Thanks. Will push a change.