Skip to content

fix: Config\Session#6998

Merged
kenjis merged 2 commits into
codeigniter4:4.3from
kenjis:fix-services-session
Dec 22, 2022
Merged

fix: Config\Session#6998
kenjis merged 2 commits into
codeigniter4:4.3from
kenjis:fix-services-session

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Dec 21, 2022 •
edited
Loading

Description
Follow-up #6989

  • use Config\Session in Services::session()
  • fix class-string class

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.3 label Dec 21, 2022
@kenjis kenjis marked this pull request as draft December 21, 2022 05:55
@kenjis kenjis changed the title fix: use Config\Session in Services::session() fix: Config\Session Dec 21, 2022
@kenjis kenjis marked this pull request as ready for review December 21, 2022 06:18
@kenjis kenjis mentioned this pull request Dec 21, 2022
Closed
5 tasks
@kenjis
fix: use Config\Session in Services
30f5a50
@kenjis
docs: fix class-string class
503ab4f 
SessionHandlerInterface does not have setLogger().
@kenjis kenjis force-pushed the fix-services-session branch from c437cf4 to 503ab4f Compare December 22, 2022 06:53
@kenjis kenjis merged commit 13d8246 into codeigniter4:4.3 Dec 22, 2022
@kenjis kenjis deleted the fix-services-session branch December 22, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @michalsn @paulbalandan