docs: add about removal of deprecated Config items#7173
Merged
samsonasik merged 1 commit intoFeb 2, 2023
Conversation
2 tasks
datamweb
approved these changes
Feb 1, 2023
samsonasik
approved these changes
Feb 2, 2023
Member
|
Thank you @kenjis |
Member
Author
|
@lonnieezell @MGatner Are you okay with this? |
Member
|
I will defer to @lonnieezell - I'm not sure why we would ever need to remove a deprecated Config item, other than the very rare collision of things. |
Member
Author
|
The reason is that there may be bugs (e.g., #4297 (comment)) that cannot be fixed, and removing them makes the code easier to read and maintain. |
lonnieezell
reviewed
Feb 2, 2023
Member
lonnieezell
left a comment
There was a problem hiding this comment.
Already been merged, but I don't have problems with this, I suppose.
Member
|
I don't think that "easier to read and maintain" is enough of a reason to remove a deprecation early. Definitely in the case of bugs - we have already discussed that allowance under our practice of "Semver". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #7021
See #7000 (comment)
backward_compatibility_notes.rstChecklist: