Simulator: add Dark/Light Mode toggle to the Simulate menu#4871
Merged
Conversation
Adds a Dark/Light Mode submenu (Dark / Light / Unsupported) under the simulator's Simulate menu that drives Display.isDarkMode(). The choice is persisted via Preferences (cn1.simulator.darkMode) and triggers refreshSkin() so themes that branch on @darkModeBool re-evaluate immediately. Default remains "Unsupported" (null), preserving the prior behavior on platforms that don't report a dark-mode state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Compared 7 screenshots: 7 matched. |
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display.isDarkMode()(Boolean.TRUE/Boolean.FALSE/null) and callsrefreshSkin(...)so themes that branch on@darkModeBoolre-render immediately.Preferencesundercn1.simulator.darkModeand restored on simulator startup. Default is still Unsupported, matching prior behavior.The previous (commented-out) skeleton in
JavaSEPort.installMenuis replaced by this active implementation.Test plan
@darkModeBool/ dark-mode CSS media queries, toggle Dark / Light / Unsupported and verify the UI re-themes immediately without restart.CN.isDarkMode()returnsnull(so theme behavior matches platforms that don't report dark mode).🤖 Generated with Claude Code