This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Split GUI into its own jar#109
Merged
Merged
Conversation
Member
|
Building the new gui jar works fine, including the deployment. But when i try to start the framework from inside IntelliJ IDEA, i got the |
Member
Author
|
Try to reload the sbt configuration inside IntelliJ (sbt window > reimport) to let IntelliJ discover the new jar. |
# Conflicts: # .gitignore
Member
|
Wow, I did not think that the solution is that easy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #102 by modifying the package task to also create a jar for the GUI. Note that the
guitask still has to be executed to actually build the GUI,packagewill just create a jar with the built GUI files.Also adds a custom
GUIServletto serve the gui over the http server because jetty wasn't able to do it if the GUI isn't included in the same jar (at least to my testing).I've also replaced the
installGuiDepsandbuildGuiwith a more generalexecuteNpmCommandto increase code reuse, because the two previous methods were almost the same.