This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Fix the support for plugin dependencies inside the plugin dev environment#125
Merged
Conversation
…ment The PomInclusionPlugin didn't work in the plugin developer environment because sbt seems to only check the unmanagedBase for auto-plugins, not unmanagedJars that was used to load the build jar. This commit moves the jar of the build code in the plugin dev environment from `bin/chatoverflow-meta-build-*.jar` to `project/lib/chatoverflow-meta-build-*.jar`. By this the jar is in the unmanagedBase directory and sbt loads the PomInclusionPlugin and the dependency support for plugins is working in the plugin dev environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PomInclusionPluginadded in #113 didn't work in the plugin developer environment because sbt seems to only check theunmanagedBasefor auto-plugins, notunmanagedJarsthat was used to load the build jar.This PR moves the jar of the build code in the plugin dev environment from
bin/chatoverflow-meta-build-*.jartoproject/lib/chatoverflow-meta-build-*.jar.By this the jar is in the
unmanagedBasedirectory and sbt loads thePomInclusionPluginand the dependency support for plugins is fixed in the plugin dev environment.