This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Add gui to the build process#17
Merged
Merged
Conversation
Member
|
Thank you for this great idea! Until we have a standalone app (way in the future), this is a good solution. While testing the code, I ran into two problems:
|
Member
Author
|
@sebinside you can now test again. The solution was to execute npm through cmd to get access to the path. |
Updated simple run configuration. Simple runs (e.g. in the plugin dev workflow) should not rebuild the GUI.
Member
|
Now everything works fine. Successfully tested on windows and mac os. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a task to sbt to build the gui and add it to the classpath. Jetty then serves the gui right from the classpath/jar. Meant to be a transition til the gui is packaged as a electron app.
Currently the gui is included in the jar of the main framework when deployed. Do you rather want it to be in a seperate jar only for the gui or is it fine in the main jar?