This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Pass functions to register method from inputs instead of methods#90
Merged
J0B10 merged 1 commit intoJul 13, 2019
Merged
Conversation
Member
|
Wow, that was quick, thank you 👍 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes fix of #89.
The problem was that we passed methods to the register/unregister methods, which take functions. In these cases scala will convert the methods to anonymous functions e.g. in the TwitchChatInput start part
onMessagewill get changed tox => onMessage(x). Because of this the function passed in the start method is not the exact same object as the one in the stop method, the handler of the input wasn't removed in the connector.Note that I only have tested this with the twitch chat input, but the handler logic similar in all other connectors it should work there too.
In the future we probably want to generalize connectors that have event handlers with some trait. Then we could place a implicit identifier in the inputs and have the connector unregister all handlers that were registered with a identifier when the plugin stops. Thats a way cleaner solution, but will require more time, so this is just for the 2.1 hotfix.