Skip to content

Refactor run completion coordination out of hostMain #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasK33 merged 3 commits into from
Apr 29, 2026
Merged

Refactor run completion coordination out of hostMain #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6666be
refactor: extract run completion coordinator
ThomasK33 Apr 29, 2026
389a9f6
review: address run completion feedback
ThomasK33 Apr 29, 2026
38b64a4
test: cover postamble flush on exit
ThomasK33 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions CONTEXT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ _Avoid_: Finished session
**Commandable Session**:
A **Session** that can still accept user input and control commands.

**Waited Run**:
A run request where the caller asks `agent-tty` to wait until the command's completion signal is observed.
_Avoid_: Blocking run

**Run Completion**:
The host-observed end point for a **Waited Run**, distinct from **Session** exit and caller timeout.
_Avoid_: Command finish, session completion

**Live Host Eligible Session**:
A **Session** where callers should ask the live session host for fresh state.

Expand Down Expand Up @@ -61,6 +69,10 @@ _Avoid_: Renderer capture
- An **Offline Replay Eligible Session** is reconstructed from its persisted **Event Log** and manifest.
- A **Snapshot Result** is derived from exactly one **Semantic Snapshot**.
- A **Snapshot Artifact** contains exactly the **Snapshot Result** emitted to the caller.
- A **Commandable Session** can accept a **Waited Run**.
- A **Waited Run** may produce one **Run Completion**, time out for its caller, or be interrupted by **Session** exit.
- Caller timeout does not cancel the underlying **Run Completion**; it may still be observed later to keep internal completion bytes out of artifacts.
- After **Session** exit, an unobserved **Run Completion** can no longer arrive.

## Example dialogue

Expand All @@ -70,6 +82,9 @@ _Avoid_: Renderer capture
> **Dev:** "Does **Snapshot Capture** ask the renderer for terminal state?"
> **Domain expert:** "No — the renderer first produces a **Semantic Snapshot**; **Snapshot Capture** derives and records the public result from that snapshot."

> **Dev:** "If a **Waited Run** times out, did the command finish?"
> **Domain expert:** "No. The caller stopped waiting, but the **Run Completion** may still arrive later and must still be recognized."

## Flagged ambiguities

- "Active" and "offline replay eligible" are independent classifications: `destroying` is both **Active** and **Offline Replay Eligible**.
Loading
Loading