Skip to content

chore: move mockRecorder to testutil package and organize fixture go variable declarations#110

Merged
pawbana merged 3 commits into
mainfrom
pb/responses-record-prompt-mock-recorder-and-fixtures
Jan 14, 2026
Merged

chore: move mockRecorder to testutil package and organize fixture go variable declarations#110
pawbana merged 3 commits into
mainfrom
pb/responses-record-prompt-mock-recorder-and-fixtures

Conversation

@pawbana
Copy link
Copy Markdown
Contributor

@pawbana pawbana commented Jan 13, 2026 •
edited
Loading

Moves mockRecorder to new interal/testutil package.
Creates fixtures/fixtures.go that contain all fixture embeddings.

This was referenced Jan 13, 2026
Merged
Merged
@pawbana Graphite App
Copy link
Copy Markdown
Contributor Author

pawbana commented Jan 13, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pawbana pawbana changed the title move mockRecorder to testutil package chore: move mockRecorder to testutil package and organize fixture go variable declarations Jan 13, 2026
@pawbana pawbana requested a review from dannykopping January 13, 2026 10:41
@pawbana pawbana marked this pull request as ready for review January 13, 2026 10:42
@pawbana pawbana force-pushed the pb/responses-record-prompt-mock-recorder-and-fixtures branch from 5552bbf to 2bad4b7 Compare January 13, 2026 17:46
dannykopping
dannykopping approved these changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment thread fixtures/fixtures.go Outdated
@pawbana pawbana force-pushed the pb/responses-record-prompt-mock-recorder-and-fixtures branch 4 times, most recently from d548099 to 6be9d94 Compare January 14, 2026 15:08
@pawbana Graphite App
Copy link
Copy Markdown
Contributor Author

pawbana commented Jan 14, 2026 •
edited
Loading

Merge activity

  • Jan 14, 3:38 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 14, 3:40 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jan 14, 3:40 PM UTC: @pawbana merged this pull request with Graphite.

@pawbana pawbana changed the base branch from pb/responses-basics to graphite-base/110 January 14, 2026 15:38
@pawbana pawbana changed the base branch from graphite-base/110 to main January 14, 2026 15:38
@pawbana pawbana force-pushed the pb/responses-record-prompt-mock-recorder-and-fixtures branch from 6be9d94 to 822f08b Compare January 14, 2026 15:39
@pawbana pawbana merged commit 9059d93 into main Jan 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pawbana @dannykopping