fix: ensure injected tool invocation results are appended to request body#189
Merged
Conversation
…t body Signed-off-by: Danny Kopping <danny@coder.com>
pawbana
approved these changes
Feb 23, 2026
Contributor
pawbana
left a comment
pawbana
left a comment
There was a problem hiding this comment.
Few nits, testing code is hacky but until refactor lands I think it is fine.
Signed-off-by: Danny Kopping <danny@coder.com>
dannykopping
added a commit
to coder/coder
that referenced
this pull request
Feb 23, 2026
See coder/aibridge#189 Signed-off-by: Danny Kopping <danny@coder.com>
dannykopping
added a commit
to coder/coder
that referenced
this pull request
Feb 23, 2026
See coder/aibridge#189 Signed-off-by: Danny Kopping <danny@coder.com>
dannykopping
added a commit
to coder/coder
that referenced
this pull request
Feb 23, 2026
See coder/aibridge#189 Signed-off-by: Danny Kopping <danny@coder.com>
dannykopping
added a commit
to coder/coder
that referenced
this pull request
Feb 23, 2026
See coder/aibridge#189 Signed-off-by: Danny Kopping <danny@coder.com>
f0ssel
pushed a commit
to coder/coder
that referenced
this pull request
Feb 23, 2026
Backports #22264 Includes fixes coder/aibridge#189 and coder/aibridge#185 Signed-off-by: Danny Kopping <danny@coder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
WithRequestBodyper-request instead of per-service, and update the payload with injected tool invocation results.Our current integration tests neglected to validate that tool results were passed after injected tool invocation, which led to a regression being introduced in #185.
Disclaimer: collaborated with Opus 4.6 on a solution