-
Notifications
You must be signed in to change notification settings - Fork 6
feat: forward client request headers to upstream providers in bridge routes #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package intercept | ||
|
|
||
| import "net/http" | ||
|
|
||
| // hopByHopHeaders are connection-level headers specific to the connection | ||
| // between client and AI Bridge, not meant for the upstream. | ||
| // See https://www.rfc-editor.org/rfc/rfc2616#section-13.5.1 | ||
| var hopByHopHeaders = []string{ | ||
| "Connection", | ||
| "Keep-Alive", | ||
| "Proxy-Authenticate", | ||
| "Proxy-Authorization", | ||
| "Te", | ||
| "Trailer", | ||
| "Transfer-Encoding", | ||
| "Upgrade", | ||
| } | ||
|
|
||
| // nonForwardedHeaders are transport-level headers managed by aibridge or | ||
| // Go's HTTP transport that must not be forwarded to the upstream provider. | ||
| var nonForwardedHeaders = []string{ | ||
|
ssncferreira marked this conversation as resolved.
|
||
| "Host", | ||
| "Accept-Encoding", | ||
| "Content-Length", | ||
| } | ||
|
|
||
| // authHeaders are headers that carry authentication credentials from the | ||
| // client. The upstream request is built by the SDK, which sets the correct | ||
| // provider credentials via option.WithAPIKey. Client auth headers are | ||
| // stripped here and the provider credentials are re-injected by | ||
| // BuildUpstreamHeaders from the SDK-built request. | ||
| var authHeaders = []string{ | ||
| "Authorization", | ||
| "X-Api-Key", | ||
| } | ||
|
|
||
| // PrepareClientHeaders returns a copy of the client headers with hop-by-hop, | ||
| // transport, and auth headers removed. | ||
| func PrepareClientHeaders(clientHeaders http.Header) http.Header { | ||
| prepared := clientHeaders.Clone() | ||
| for _, h := range hopByHopHeaders { | ||
| prepared.Del(h) | ||
| } | ||
| for _, h := range nonForwardedHeaders { | ||
| prepared.Del(h) | ||
| } | ||
| for _, h := range authHeaders { | ||
| prepared.Del(h) | ||
| } | ||
| return prepared | ||
| } | ||
|
|
||
| // BuildUpstreamHeaders produces the header set for an upstream SDK request. | ||
| // It starts from the prepared client headers, then preserves specific | ||
| // headers from the SDK-built request that must not be overwritten. | ||
| func BuildUpstreamHeaders(sdkHeader http.Header, clientHeaders http.Header, authHeaderName string) http.Header { | ||
| headers := PrepareClientHeaders(clientHeaders) | ||
|
|
||
| // Preserve the auth header set by the SDK from the provider configuration. | ||
| if v := sdkHeader.Get(authHeaderName); v != "" { | ||
| headers.Set(authHeaderName, v) | ||
| } | ||
|
|
||
| // Preserve actor headers injected by aibridge as per-request SDK options. | ||
| for name, values := range sdkHeader { | ||
| if IsActorHeader(name) { | ||
| headers[name] = values | ||
| } | ||
| } | ||
|
|
||
| return headers | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will handle this in a follow-up in order to not increase the scope of this PR.