Skip to content

Conversation

@kylecarbs
Copy link
Member

Summary

Makes the agent access page production-ready by:

1. Remove "Public" visibility option

  • Deleted the disabled "Public (Coming Soon)" radio button from the visibility section
  • It was non-functional and cluttered the UI

2. Move permissions table to a modal

  • Converted the always-visible PermissionsReference card to a modal dialog
  • Added a "What can each role do?" trigger link near the Add Member button
  • Modal is dismissible via backdrop click and X button

3. Display all users with inherited access

  • When visibility is "organization", now shows ALL org members in the table with their effective access:
    • Org owners/admins → Admin (via Team Owner/Admin role)
    • Org members → Read (via Team Member status)
    • Explicit grants are shown separately with "Direct" source
  • Added "Source" column showing access source (Team Owner, Team Admin, Team Member, Direct)
  • Users with explicit grants are excluded from the inherited members list to avoid duplication

4. Fix UserSelector dropdown focus bug

  • Added inputRef and auto-focus logic when dropdown opens
  • Added stopPropagation handlers on the input to prevent Radix from stealing focus
  • First keystroke now works reliably

Testing

  • Verified TypeScript compiles (pre-existing errors in other files are unrelated)
  • Changes are UI-only, no backend modifications needed

- Remove disabled 'Public (Coming Soon)' visibility option
- Move permissions reference table into a modal dialog
- Display all org members with inherited access when visibility is 'organization'
- Show access source (Team Owner/Admin, Team Member, Direct) in members table
- Fix UserSelector dropdown focus bug by auto-focusing search input on open
@vercel
Copy link

vercel bot commented Dec 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
blink Ready Ready Preview, Comment Dec 31, 2025 3:52pm

@kylecarbs kylecarbs merged commit 2ca6bba into main Dec 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant