Skip to content

fix: add missing package.json and source maps #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-asher merged 6 commits into from
Mar 30, 2022
+70 −36
Merged

fix: add missing package.json and source maps #5040

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d9b15e
Use --exclude to skip node_modules
code-asher Mar 29, 2022
4107f11
Remove per-extension dependency install
code-asher Mar 29, 2022
ede7125
Include source maps
code-asher Mar 29, 2022
c24fa95
Refresh language patch
code-asher Mar 29, 2022
f228cc9
Add missing package.json
code-asher Mar 29, 2022
4ae5e26
Include keytar
code-asher Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ci/build/build-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,8 @@ EOF
) > "$VSCODE_OUT_PATH/product.json"

# Use the package.json for the web/remote server. It does not have the right
# version though so pull that from the main package.json. Also remove keytar
# since the web does not rely on it and that removes the dependency on
# libsecret.
jq --slurp '.[0] * {version: .[1].version} | del(.dependencies.keytar)' \
# version though so pull that from the main package.json.
jq --slurp '.[0] * {version: .[1].version}' \
Comment on lines +139 to +140
Copy link
Contributor

@jsjoeio jsjoeio Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! How'd you figure this out? That log message when code-server starts up? IIRC

Copy link
Member Author

@code-asher code-asher Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup hahaha, no idea how I did not see it before

Copy link
Member Author

@code-asher code-asher Mar 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately we still have libsecret as a dependency (which keytar needs) in our docs (as far as I could tell, hopefully I did not miss a spot) so nothing else changes

"$VSCODE_SRC_PATH/remote/package.json" \
"$VSCODE_SRC_PATH/package.json" > "$VSCODE_OUT_PATH/package.json"

Expand Down